feat(health): add /health/dependencies with onchain_rpc_ms latency check#357
Merged
kilodesodiq-arch merged 1 commit intoJul 17, 2026
Conversation
This was referenced Jul 16, 2026
Contributor
|
Awesome work on this! Thanks for the contribution 🚀 Merging now. |
ifygreg01-best
pushed a commit
to ifygreg01-best/ChainForge
that referenced
this pull request
Jul 23, 2026
…eck (ChainForgee#357) Closes ChainForgee#287 Co-authored-by: Bukee <viewbukky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #344 (repackaged to remove unrelated files accidentally included by lint --fix).
**Closes #287
Summary
Adds a new
GET /api/v1/health/dependenciesendpoint that measures on-chain RPC latency and reports it asonchain_rpc_ms.degraded(still HTTP 200 — the service is alive, just slow, so monitoring can see the number).down(HTTP 503).checkOnchainContract()pattern inHealthService.Note on
getAdmin(): the issue references agetAdmin()RPC call, butOnchainAdapterdoesn't currently expose one. I used the existing read-onlygetContractMetadata()call to measure latency and left a comment on the issue asking whether a dedicatedgetAdmin()method is preferred. Swapping it is a one-line change if so.Testing
pnpm build(backend) passes — clean type-check.pnpm test:e2e healthpasses:The e2e test overrides the on-chain adapter with a fast fake, so it verifies the endpoint's behaviour without touching a live network.
Checklist